Repository navigation
Fix a flaky reveal test - #4
Merged
Merged
Conversation
The test compared animation delays measured from the real clock, with no tolerance. Once the queue sits at maxWaveLagMs both delays are 240 ms up to floating-point rounding, so it failed at random (240 vs 240.0000000000001 on CI). The clock is now frozen for the test, and the comparison allows a thousandth of a millisecond, far below the 36 ms a reused slot would cost.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RevealProvider reset-key test compared animation delays measured from the real clock with no tolerance, and failed at random on CI (240 vs 240.0000000000001) once the queue was held at maxWaveLagMs. The clock is now frozen for the test and the comparison allows 0.001 ms, far below the 36 ms stagger that a reused slot would show. Library code is unchanged.